[
https://issues.apache.org/jira/browse/TEZ-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694711#comment-14694711
]
Hitesh Shah commented on TEZ-2300:
----------------------------------
Couple of minor comments ( without addressing the api/semantic aspects ):
- should TEZ_CLIENT_HARD_KILL_TIMEOUT_MS_DEFAULT support -1?
- typo in "TEZ_CLIENT_HARD_KILL_TIMEOUT_MS = TEZ_TASK_PREFIX + "timeout-ms";"
i.e. client prefix and not task prefix
{code}
} catch (Exception e) {
Assert.fail("Expected ApplicationNotFoundException");
}
- The expected exception within the catch block is a bit confusing at a
first glance
{code}
verify(client.mockYarnClient,
atLeast(2)).getApplicationReport(client.mockAppId);
{code}
- is there a chance of this being flaky as it is timing dependent given that
there is a sleep of 1000L and hard kill timeout is set to 2000.
> TezClient.stop() takes a lot of time or does not work sometimes
> ---------------------------------------------------------------
>
> Key: TEZ-2300
> URL: https://issues.apache.org/jira/browse/TEZ-2300
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Rohini Palaniswamy
> Assignee: Jonathan Eagles
> Attachments: TEZ-2300.1.patch, TEZ-2300.2.patch, TEZ-2300.3.patch,
> syslog_dag_1428329756093_325099_1_post
>
>
> Noticed this with a couple of pig scripts which were not behaving well (AM
> close to OOM, etc) and even with some that were running fine. Pig calls
> Tezclient.stop() in shutdown hook. Ctrl+C to the pig script either exits
> immediately or is hung. In both cases it either takes a long time for the
> yarn application to go to KILLED state. Many times I just end up calling yarn
> application -kill separately after waiting for 5 mins or more for it to get
> killed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
