[
https://issues.apache.org/jira/browse/TEZ-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708812#comment-14708812
]
Jeff Zhang commented on TEZ-2708:
---------------------------------
[~sseth] Not sure how you generate the patch, after I apply the patch, see the
following compilation error, seems the rename don't take effect.
{noformat}
/Users/jzhang/github/tez/tez-api/src/main/java/org/apache/tez/common/ContainerSignatureMatcher.java:[28,8]
class ExecutorSignatureMatcher is public, should be declared in a file named
ExecutorSignatureMatcher.java
[ERROR]
/Users/jzhang/github/tez/tez-dag/src/main/java/org/apache/tez/dag/app/TaskAttemptListenerImpTezDag.java:[72,8]
class TaskCommunicatorManager is public, should be declared in a file named
TaskCommunicatorManager.java
[ERROR]
/Users/jzhang/github/tez/tez-dag/src/main/java/org/apache/tez/dag/app/rm/container/ContainerContextMatcher.java:[31,8]
class ExecutorContextMatcher is public, should be declared in a file named
ExecutorContextMatcher.java
[ERROR]
/Users/jzhang/github/tez/tez-dag/src/main/java/org/apache/tez/dag/app/launcher/ContainerLauncherImpl.java:[67,8]
class TezContainerLauncherImpl is public, should be declared in a file named
TezContainerLauncherImpl.java
[ERROR]
/Users/jzhang/github/tez/tez-dag/src/main/java/org/apache/tez/dag/app/rm/TaskSchedulerEventHandler.java:[92,8]
class TaskSchedulerManager is public, should be declared in a file named
TaskSchedulerManager.java
{noformat}
* Do you intend to expose the concept Executor to replace Container ( Yarn
Container would be just one kind of Executor ) ?
I see both Executor (ExecutorSignaureMatcher) and Container (ContainerLauncher
etc) related classes in tez-api, might be confusing to users.
* DAGAppMaster#createContainerSignatureMatcher ->
DAGAppMaster#createExecutorSignatureMatcher
* ExecutorContextMatcher -> YarnExecutorSignatureMatcher (Will there be
ExecutorSignatureMatcherManager too in the future ? )
* TaskSchedulerContext#getContainerSignatureMatcher -->
TaskSchedulerContext#getExecutorSignatureMatcher
* ContainerLauncherRouter --> ContainerLauncherManager ?
> renames for tez-2003 changes
> ----------------------------
>
> Key: TEZ-2708
> URL: https://issues.apache.org/jira/browse/TEZ-2708
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: TEZ-2003
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-2708.1.txt, TEZ-2708.2.txt
>
>
> This jira is to track some class renames which are required. TBD just before
> merging or right after the merge.
> - ContainerLauncherImpl to TezContainerLauncherImpl ? Make all the default
> implementation with prefix Tez.
> - TaskAttemptListenerImpTezDag to TaskCommunicatorManager
> - Likewise for tests.
> - Remove TezTaskRunner
> - Rename TaskSchedulerEventHandler
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
