[
https://issues.apache.org/jira/browse/TEZ-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709802#comment-14709802
]
Siddharth Seth commented on TEZ-2708:
-------------------------------------
[~zjffdu] - thanks for taking a look.
The patch was generated using git diff -M - which should make it a lot easier
to review, in terms of the renamed files. Apply using "git apply -p0 -v
<filename>". I'm not sure why one run of jenkins succeeded and the other did
not.
You bring up some good points about Container / Executor. I'm going to drop the
rename of ContainerSignatureMatcher to ExecutorSIgnatureMatcher in this patch,
and instead leave that for the jira where we get rid of YARN containers being
exposed.
Uploading a new patch in a bit, with the following additional changes.
- ContainerLauncherRouter renamed to ContainerLauncherManager
- NMCommEvent and NMCommEventType renamed to ContainerLauncherEvent and
ContainerLauncherEventType
- TestContainerLauncherRouter renamed to TestContainerLauncherManager
- TestTaskSchedulerEventHandler renamed to TestTaskSchedulerManager
- Changed findbugs-exlcude to reflect the updated names.
> renames for tez-2003 changes
> ----------------------------
>
> Key: TEZ-2708
> URL: https://issues.apache.org/jira/browse/TEZ-2708
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: TEZ-2003
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-2708.1.txt, TEZ-2708.2.txt
>
>
> This jira is to track some class renames which are required. TBD just before
> merging or right after the merge.
> - ContainerLauncherImpl to TezContainerLauncherImpl ? Make all the default
> implementation with prefix Tez.
> - TaskAttemptListenerImpTezDag to TaskCommunicatorManager
> - Likewise for tests.
> - Remove TezTaskRunner
> - Rename TaskSchedulerEventHandler
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
