[ 
https://issues.apache.org/jira/browse/TEZ-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716935#comment-14716935
 ] 

Siddharth Seth commented on TEZ-2745:
-------------------------------------

This is going off topic for the jira - but continuing on the cleanup aspects.
As an example of cleanup - InputInitializer, VertexManagerPlugin, 
EdgeManagerPlugin - none of these have a close() method. If an exception 
originates from one of these sources - or for that matter the DAG fails for any 
other reason, there's no explicit call to clean up these plugins. If any of 
them happened to have started a thread - that may not get cleaned up.
Also, we catch throwables and not exceptions - which means the AM may not be in 
a state to accept a new DAG after one fails.

> ClassNotFoundException of user code should fail dag
> ---------------------------------------------------
>
>                 Key: TEZ-2745
>                 URL: https://issues.apache.org/jira/browse/TEZ-2745
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.0, 0.5.4, 0.6.2, 0.8.0-alpha
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2745-1.patch, TEZ-2745-2.patch
>
>
> This ClassNotFoundException is not captured now. The current behavior is AM 
> crashed and relaunched again until max app attempt is reached. 
> Here's user code used in AM:
> * EdgeManager
> * VertexManager
> * InputInitializer
> * OutputCommitter
> * Other user pluggable components (like DAGScheduler, HistoryServiceLogging 
> etc.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to