[ 
https://issues.apache.org/jira/browse/TEZ-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954204#comment-14954204
 ] 

TezQA commented on TEZ-1692:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12766203/TEZ-1692.1.txt
  against master revision 822bc69.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.
        See 
https://builds.apache.org/job/PreCommit-TEZ-Build/1211//artifact/patchprocess/diffJavadocWarnings.txt
 for details.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new 
Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1211//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1211//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1211//console

This message is automatically generated.

> Reduce code duplication between TezMapredSplitsGrouper and 
> TezMapreduceSplitsGrouper
> ------------------------------------------------------------------------------------
>
>                 Key: TEZ-1692
>                 URL: https://issues.apache.org/jira/browse/TEZ-1692
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-1692.1.txt
>
>
> The two are almost identical - with lots of repeated logic. The main 
> difference being the mapred / mapreduce InputSplit being grouped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to