[ 
https://issues.apache.org/jira/browse/TEZ-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955652#comment-14955652
 ] 

Siddharth Seth commented on TEZ-1692:
-------------------------------------

Hive still builds.
Fixed the typo.
Removed SplitHolder (but it may not be the most efficient removal). This does 
have the drawback of mixing Processing logic into SplitContainer. That's OK for 
now though - since these classes exist primarily for Grouping.
Had left the constructors - since they're public - in theory anyway.
I'd prefer skipping a large grouping test. Do you see something specific that 
could cause a large increase in resource utilization ? This is useful to have, 
but is better added as it's own jira.

> Reduce code duplication between TezMapredSplitsGrouper and 
> TezMapreduceSplitsGrouper
> ------------------------------------------------------------------------------------
>
>                 Key: TEZ-1692
>                 URL: https://issues.apache.org/jira/browse/TEZ-1692
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-1692.1.txt, TEZ-1692.2.txt, TEZ-1692.3.txt
>
>
> The two are almost identical - with lots of repeated logic. The main 
> difference being the mapred / mapreduce InputSplit being grouped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to