[
https://issues.apache.org/jira/browse/TEZ-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997530#comment-14997530
]
Hitesh Shah edited comment on TEZ-2924 at 11/9/15 10:34 PM:
------------------------------------------------------------
bq. Adds a dependency on 2.8.0-SNAPSHOT ?
Removed. use of provided was also messing with the build. For now, I will just
"doc" this to use the correct hadoop version with the correct build profile.
bq. Will the shimLoaders evolve ? i.e. if a 2.9.0 were to be released with
additional features ...
Good point. Changed 2.8 to be a strict check. Also, made base classes abstract
instead of interfaces for future proofing extensions.
bq. Log statements
They are in the loader class.
bq. Will there ever be a situation when multiple shims match a specific version
?
Can be but current code is first one wins.
bq. some fields can be made final - initialize collapsed into the constructor,
etc
Done.
bq. Are multiple instances of HadoopShimLoader meant to be created within a JVM
Not really but have kept it open for now.
bq. Annotate various interfaces with the Private annotation ?
Done. Kept the main interfaces public unstable for now.
was (Author: hitesh):
bq. Adds a dependency on 2.8.0-SNAPSHOT ?
Removed.
bq. Will the shimLoaders evolve ? i.e. if a 2.9.0 were to be released with
additional features ...
Good point. Changed 2.8 to be a strict check. Also, made base classes abstract
instead of interfaces for future proofing extensions.
bq. Log statements
They are in the loader class.
bq. Will there ever be a situation when multiple shims match a specific version
?
Can be but current code is first one wins.
bq. some fields can be made final - initialize collapsed into the constructor,
etc
Done.
bq. Are multiple instances of HadoopShimLoader meant to be created within a JVM
Not really but have kept it open for now.
bq. Annotate various interfaces with the Private annotation ?
Done. Kept the main interfaces public unstable for now.
> Framework for Hadoop shims
> --------------------------
>
> Key: TEZ-2924
> URL: https://issues.apache.org/jira/browse/TEZ-2924
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: TEZ-2924.2.patch, TEZ-2924.wip.1.patch
>
>
> As Hadoop creates a matrix of which versions support what features, Tez will
> need a shim to be cross-compatible and make use of various fixes/features as
> and when possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
