[ 
https://issues.apache.org/jira/browse/TEZ-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053443#comment-15053443
 ] 

Hitesh Shah commented on TEZ-2977:
----------------------------------

bq. versionOverride 

Yes - currently the tests can fail depending on which default hadoop.version is 
set in the pom hence the versionOverride for a safer approach. 

bq. The override tests in TestHadoopShims<version>Provider - they seem to be 
overriding with the Provider which would have been returned irrespective of the 
override ?

Same reason - the default version can cause the default provider to be picked 
up. There is a basic test in TestHadoopShimsLoader which does a check on the 
Dummy provider being chosen. The others are redundant to some extent but help 
catch some edge cases. 



> Make HadoopShim selection be overridable for distro-specific implementations
> ----------------------------------------------------------------------------
>
>                 Key: TEZ-2977
>                 URL: https://issues.apache.org/jira/browse/TEZ-2977
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-2977.1.patch, TEZ-2977.2.patch
>
>
> Distro-specific hadoop versions may not be aligned with Apache releases and 
> therefore a configurable override may be useful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to