[
https://issues.apache.org/jira/browse/TEZ-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059163#comment-15059163
]
Siddharth Seth commented on TEZ-2910:
-------------------------------------
Minor comments mostly
- (1) RootInputInitializerManager - call() - does not clear the Caller context.
This is ok rightnow, since there's a new RootInputInitializerManager for each
vertex, and the threadpool is not shared. However, this can change later - so
it's safer to unset, or leave a comment.
- VMs/EMs in theory should run under the context. Also - the pluggable
services. However, I think these can be done later - since these components are
not expected to read/write to HDFS. Follow up jira ?
For a follow up jira - potentially set callerContext at the app level, then add
the dag level. Unsetting dag does not unset app. This would require a huge
change though - similar to the UGI for the AsyncDispatcher being tied to the AM
ugi rather than the DAG UGI.
+1 after fixing (1), RootInputInitializerManager.
> Set caller context for tracing ( integrate with HDFS-9184 )
> ------------------------------------------------------------
>
> Key: TEZ-2910
> URL: https://issues.apache.org/jira/browse/TEZ-2910
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: TEZ-2910.3.patch, TEZ-2910.4.patch,
> TEZ-2910.branch-0.7-wip.1.patch, TEZ-2910.wip.1.patch, TEZ-2910.wip.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
