[
https://issues.apache.org/jira/browse/TEZ-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139944#comment-15139944
]
Hitesh Shah commented on TEZ-3090:
----------------------------------
{code}
private static String getStringProperty(Configuration conf, String
propertyName) {
713 Preconditions.checkNotNull(conf, "Configuration must be provided");
714 String propertyString = conf.get(propertyName);
715 Preconditions.checkNotNull(propertyString,
716 "Property " + propertyName + " not found in provided
configuration");
717 return propertyString;
718 }
719
720 private static int getIntProperty(Configuration conf, String
propertyName) {
721 return Integer.parseInt(getStringProperty(conf, propertyName));
722 }
723
{code}
Isnt the above a bit of an overkill? Why not just use conf.getInt() etc and
with -1 as say the default value and document the api accordingly?
> MRInput should make dagIdentifier, vertexIdentifier, etc available to the
> InputFormat jobConf
> ---------------------------------------------------------------------------------------------
>
> Key: TEZ-3090
> URL: https://issues.apache.org/jira/browse/TEZ-3090
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-3090.1.txt, TEZ-3090.2.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
