[
https://issues.apache.org/jira/browse/TEZ-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139968#comment-15139968
]
Hitesh Shah commented on TEZ-3029:
----------------------------------
Comments:
- dag names are not unique. On error should not use it as an identifier.
- non-needed change in ContainerLauncher.java?
- why is ServicePluginError needed? Doesnt the fatal error reporting handle
the permanent case? UPDATE: Looks like onError is being removed - should tag
this jira as an incompatible change?
- processNonFatalServiceErrorReport() - shouldnt this fail the dag instead of
killing it?
- s/diag= "/diagnostics="/ - better for readability.
> Add an onError method to service plugin contexts
> ------------------------------------------------
>
> Key: TEZ-3029
> URL: https://issues.apache.org/jira/browse/TEZ-3029
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-3029.1.txt
>
>
> This is to indicate errors which may occur while running threads etc.
> One bit to be careful about is that this introduces two means of reporting
> errors - which has been challenging to handle in the past for
> Input/Processor/OutputContext - so whether to do this or not needs to be
> thought through.
> TaskSchedulerContext already has this method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
