[ 
https://issues.apache.org/jira/browse/TEZ-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142155#comment-15142155
 ] 

Bikas Saha commented on TEZ-3029:
---------------------------------

Why add a new DAGInfo when there is an existing DagIdentifier that provides the 
necessary information. DagIdentifier is already a public facing entity for 
users to dag related information. What is the need to add another entity?

The ServicePluginErrorDefaults/ServicePluginError pattern seems strange (as 
does returning a base Enum type). What is the need for an extra 
ServicePluginError interface? If it is an interface because different plugins 
can have different errors and end receivers of these errors will need to cast 
objects to get access to the actual enum type then the bare enum type being 
forced on the interface seems not clean. After casting objects, user can use 
appropriate type specific methods (with potentially richer information than 
Enums).

> Add an onError method to service plugin contexts
> ------------------------------------------------
>
>                 Key: TEZ-3029
>                 URL: https://issues.apache.org/jira/browse/TEZ-3029
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-3029.1.txt, TEZ-3029.2.txt
>
>
> This is to indicate errors which may occur while running threads etc.
> One bit to be careful about is that this introduces two means of reporting 
> errors - which has been challenging to handle in the past for 
> Input/Processor/OutputContext - so whether to do this or not needs to be 
> thought through.
> TaskSchedulerContext already has this method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to