[ 
https://issues.apache.org/jira/browse/TEZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143593#comment-15143593
 ] 

Bikas Saha commented on TEZ-3107:
---------------------------------

finishTime should be greater than startTime, right?
{code}+      if (finishTime > startTime) {
+        LOG.warn("DAG finish time is greater than start time. "
+            + "startTime=" + startTime
+            + ", finishTime=" + finishTime
+        );
+      }{code}

Could we add some test conditions to existing TestHistoryParser to catch such 
regression early. This patch will help workaround the bug for existing 
deployments of the previous release. Having the test would help catch 
regression like those fixed in TEZ-3032.

> tez-tools: Log warn msgs in case ATS has wrong values (e.g startTime > 
> finishTime)
> ----------------------------------------------------------------------------------
>
>                 Key: TEZ-3107
>                 URL: https://issues.apache.org/jira/browse/TEZ-3107
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>             Fix For: 0.7.1
>
>         Attachments: TEZ-3107.1.patch
>
>
> Have seen couple of DAGs where startTime > finishTime in ATS data.  Though we 
> need to root cause and fix to have ATS log correct timestamps, we can at 
> least log warn msgs in ATS parser. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to