[
https://issues.apache.org/jira/browse/TEZ-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143935#comment-15143935
]
Bikas Saha commented on TEZ-3107:
---------------------------------
lgtm except for these 2 if stmts
{code}
+ if (finishTime > startTime) { <<<<<<<<<<
+ LOG.warn("DAG finish time is smaller than start time. "
+ + "startTime=" + startTime
+ + ", finishTime=" + finishTime
+ );
+ }
DAGFinishedEvent finishEvt = new DAGFinishedEvent(dagId, startTime,
finishTime, DAGState.SUCCEEDED, "", counters,
this.userName, this.dagName, taskStats,
this.appContext.getApplicationAttemptId(),
@@ -1245,6 +1251,12 @@ public class DAGImpl implements
org.apache.tez.dag.app.dag.DAG,
if (recoveryData == null
|| recoveryData.getDAGFinishedEvent() == null) {
Map<String, Integer> taskStats = constructTaskStats(getDAGProgress());
+ if (finishTime > startTime) { <<<<<<<<<<<<<
{code}
> tez-tools: Log warn msgs in case ATS has wrong values (e.g startTime >
> finishTime)
> ----------------------------------------------------------------------------------
>
> Key: TEZ-3107
> URL: https://issues.apache.org/jira/browse/TEZ-3107
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Rajesh Balamohan
> Fix For: 0.7.1
>
> Attachments: TEZ-3107.1.patch, TEZ-3107.3.patch
>
>
> Have seen couple of DAGs where startTime > finishTime in ATS data. Though we
> need to root cause and fix to have ATS log correct timestamps, we can at
> least log warn msgs in ATS parser.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
