[
https://issues.apache.org/jira/browse/TEZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176507#comment-15176507
]
Siddharth Seth commented on TEZ-3077:
-------------------------------------
Comments on the patch, and apologies for the late review.
- We should not change the behaviour of the existing waitTillReady API - that's
a backward incompatible change
- Instead of defining a configuration parameter, a new method
waitTillReady(long timeout, TimeUnit timeUnit) should be sufficient.
- Please ignore my comment earlier about throwing a TimeoutException - a return
status (boolean) would be more consistent with the way such time based APIs
work in Java libraries. e.g.
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/Condition.html#await(long,%20java.util.concurrent.TimeUnit),
or
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/BlockingQueue.html#poll(long,%20java.util.concurrent.TimeUnit)
- It should be possible to make use of this new method in the existing
waitTillReady with an infinite timeout (0)
- Also, the sleep interval in this new method would need to be modified to
match with the timeout specified in the api cal. i.e. min(SLEEP_FOR_READY,
sleepTimeRemaining)
> TezClient.waitTillReady should support timeout
> ----------------------------------------------
>
> Key: TEZ-3077
> URL: https://issues.apache.org/jira/browse/TEZ-3077
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Kuhu Shukla
> Attachments: TEZ-3077.001.patch
>
>
> Also preWarm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
