[
https://issues.apache.org/jira/browse/TEZ-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386540#comment-15386540
]
Hitesh Shah commented on TEZ-3358:
----------------------------------
Comments:
- pom.xml changes need to be reverted.
- " numDagsPerGroup =
conf.getInt(TezConfiguration.TEZ_HISTORY_LOGGING_NUM_DAGS_PER_GROUP, -1);" -
should use a defined var for -1.
- "numDagsPerGroup > 0" - should this be > 1? Likewise for TEZ-3357.
-
{code}
assertTrue(timelineClient.entityLog.containsKey(
93 TimelineEntityGroupId.newInstance(appId,
dagId1.getGroupId(numDagsPerGroup))));
{code}
- this check could be enhanced to assert for counts in correct group ids as
well as ensuring that correct events are routed into the correct group id.
- test could be enhanced to verify normal backwrad-compat behavior vs when
the group count is set to a value higher than 1.
> Group ATSLogs for multiple DAGs into one file.
> ----------------------------------------------
>
> Key: TEZ-3358
> URL: https://issues.apache.org/jira/browse/TEZ-3358
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Harish Jaiprakash
> Assignee: Harish Jaiprakash
> Attachments: TEZ-3358.01.patch
>
>
> Currently we create one history log file per DAG, change to use one group for
> multiple DAGs to prevent creation of too many files on hdfs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
