[ 
https://issues.apache.org/jira/browse/TEZ-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387146#comment-15387146
 ] 

Hitesh Shah commented on TEZ-3358:
----------------------------------

Minor comments - mostly looks good: 

  - testDAGGroupingGroupingEnabled - please add one more dag where id > 100 to 
do the full verification on use of diff group Ids. 
  - please cap line lengths to 100. Some code in 
TestATSV15HistoryLoggingService is over this limit. 

> Group ATSLogs for multiple DAGs into one file.
> ----------------------------------------------
>
>                 Key: TEZ-3358
>                 URL: https://issues.apache.org/jira/browse/TEZ-3358
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Harish Jaiprakash
>            Assignee: Harish Jaiprakash
>         Attachments: TEZ-3358.01.patch, TEZ-3358.02.patch
>
>
> Currently we create one history log file per DAG, change to use one group for 
> multiple DAGs to prevent creation of too many files on hdfs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to