[
https://issues.apache.org/jira/browse/TEZ-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442489#comment-15442489
]
Hitesh Shah commented on TEZ-3404:
----------------------------------
bq. In session mode, should dag domain id be created even when there are no dag
acls? But if its not ok, I'll revert to the older behaviour.
Definitely not ok to change behavior. The unit test definitely should not
change to account for a behavior modification. Please revert. No dag acls
implies only the dag owner should be the only one to be able to view the dag.
Not setting a domain means all data is visible to everyone.
bq. DagAppMaster submits AMLaunchedEvent even before historyService has been
started (during the init phase itself)
Waiting for all the services to start might mean that the launched event never
goes through if one of the services fails to start. It would be good to see if
we can address this dependency in a clean way.
bq. I wanted the name to indicate that it merges into AM Acl config, changed it
to dag.getDagAccessControls().mergeIntoAmAcls.
Makes sense now. Javadocs on the function would help.
bq. The DAG acls were already being serialized into config, I only wrote the
deserialize part.
This was being done earlier probably as a result of using config to communicate
with the pluggable policy managers. Might be a good idea to fix this correctly.
bq. Submit event always has a config, but the recover event did not have one,
so used the config from currentDag, hope that is alright?
Seems reasonable. A code comment would help.
> Remove blocking call for ATS domain creation from client side to AM
> -------------------------------------------------------------------
>
> Key: TEZ-3404
> URL: https://issues.apache.org/jira/browse/TEZ-3404
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Harish Jaiprakash
> Assignee: Harish Jaiprakash
> Attachments: TEZ-3404-WIP-01.patch, TEZ-3404-WIP-02.patch,
> TEZ-3404-WIP-03.patch, TEZ-3404-WIP-04.patch, TEZ-3404-WIP-05.patch
>
>
> Today, there is a blocking call for creating the domain on the client side
> which blocks hive query throughput. We need to move this to the AM and still
> retain the same security guarantees.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
