[
https://issues.apache.org/jira/browse/TEZ-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444451#comment-15444451
]
Harish Jaiprakash commented on TEZ-3404:
----------------------------------------
bq. Is there a reason the patches are still being tagged as work in progress?
Oops, sorry about that. I was only changing the diff command mechanically. Its
not work in progress anymore.
bq. I am not sure I understand. It seems like this is an incompatible change?
What if someone already has their own impl of the policy manager? Do they need
to change after this patch goes in?
The contract for HistoryACLPolicyManager seems to be too wide, the biggest
difference is that earlier if the client explicitly set a domain using
YARN_ATS_ACL_SESSION_DOMAIN_ID or YARN_ATS_ACL_DAG_DOMAIN_ID then the policy
manager would return null. Now in this case it returns domain id from the
configured value. There are 3 different decision which has to be taken: use a
domain id, disable history logging, disable acls. I assumed that the policy
manager should be responsible for these and set it as non null, exception and
null return for them correspondingly. As opposed to the earlier impl which was
created domain id = non null (use this), failed to create: exception (disable
history logging), null return (might have to disable acls or fallback to
default). In the last case checks and code were repeated in both acl policy
manager and history logger.
W.r.t to incompatible changes, I do not think it should affect us, both our
historyLoggers instantiate their corresponding ACL managers through a constant
in the corresponding classes, so these are not pluggable. If someone has their
own history logger impl, then it does not matter. Please do advise if my
assumption are alright?
> Remove blocking call for ATS domain creation from client side to AM
> -------------------------------------------------------------------
>
> Key: TEZ-3404
> URL: https://issues.apache.org/jira/browse/TEZ-3404
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Harish Jaiprakash
> Assignee: Harish Jaiprakash
> Attachments: TEZ-3404-WIP-01.patch, TEZ-3404-WIP-02.patch,
> TEZ-3404-WIP-03.patch, TEZ-3404-WIP-04.patch, TEZ-3404-WIP-05.patch,
> TEZ-3404-WIP-06.patch, TEZ-3404-WIP-07.patch, TEZ-3404-WIP-08.patch
>
>
> Today, there is a blocking call for creating the domain on the client side
> which blocks hive query throughput. We need to move this to the AM and still
> retain the same security guarantees.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
