[ 
https://issues.apache.org/jira/browse/TEZ-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kuhu Shukla updated TEZ-3437:
-----------------------------
    Attachment: TEZ-3437.009.patch

Thank you [~sseth], sorry I missed that change.
Updated patch addressing comments above, also added IOException and 
InterruptedException to {{getProgress}} for readers (which was added in 
TEZ-3317), now modeled after {{MRReader}}. Let me know if this seems reasonable 
 since some of the readers' {{getProgress}} call would not actually throw these 
exceptions, for example : {{ConcatenatedMergedKeyValuesReader#getProgress}}.

If the Input uses the reader's progress, an IOException is thrown as 
ProgressFailedException. An InterruptedException is thrown as-is.

Includes null check for {{scheduledExecutorService}} which is now volatile in 
ProgressHelper.

Appreciate more comments/review.

> Improve synchronization and the progress report behavior for Inputs from 
> TEZ-3317
> ---------------------------------------------------------------------------------
>
>                 Key: TEZ-3437
>                 URL: https://issues.apache.org/jira/browse/TEZ-3437
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>         Attachments: TEZ-3437.001.patch, TEZ-3437.002.patch, 
> TEZ-3437.003.patch, TEZ-3437.004.patch, TEZ-3437.005.patch, 
> TEZ-3437.006.patch, TEZ-3437.007.patch, TEZ-3437.008.patch, TEZ-3437.009.patch
>
>
> Follow up from TEZ-3317 to improve the getProgress thread synchronization and 
> replace timerTasks with ScheduledExecutorService. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to