[
https://issues.apache.org/jira/browse/TEZ-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550017#comment-15550017
]
Hitesh Shah commented on TEZ-3432:
----------------------------------
Comments:
- s/waitForAppTimeout/waitForAppCompletion/ -
- "Assert.assertEquals("Session timed out", diagnostics.get("Session timed
out"));" - this is better off done by via assertTrue(string.contains())
- "Assert.assertTrue(amShutdownTime - lastDAGCompletionTime < 5500);
//Testing with 10% buffer" - was this tried on a VM for example? The 0.5
seconds buffer seems potentially flaky.
- "public HashMap<String, String> getDiagnostics(YarnClient yarnClient,
ApplicationId appId) throws Exception {"
- should return a map and not a hashmap
- should take in just diagnostics string as input arg
- should not need throws Exception after args are changed
- as part of invoking the function, there should be checks to ensure that
diagnostics is not null and not empty.
- Seems like the parsing code might throw an error when it hits something
like ", foo=," ?
> Add unit test for session timeout
> ---------------------------------
>
> Key: TEZ-3432
> URL: https://issues.apache.org/jira/browse/TEZ-3432
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Sushmitha Sreenivasan
> Assignee: Sreenath Somarajapuram
> Labels: newbie
> Attachments: TEZ-3432.1.patch, TEZ-3432.2.patch, TEZ-3432.3.patch
>
>
> Add unit test which sets tez.session.am.dag.submit.timeout.secs to say 5 secs
> and checking if dag submission timeouts after the configured time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
