[
https://issues.apache.org/jira/browse/TEZ-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605583#comment-15605583
]
Hitesh Shah commented on TEZ-3470:
----------------------------------
bq. As frontend-maven-plugin & exec-maven-plugin doesn't respect the phase we
are forced to use <skip>
Can you clarify a bit more on this? Are you saying the tez-ui UTs get executed
even when mvn test is not called? As an example, the tez-ui pom clearly
indicates that the frontend plugin is being invoked in the generate-resources
phase.
Comments on the patch:
- There is no mention on why we need a flag on needing to skip tests in this
jira. Can you explain why the changes are needed? I see TEZ-3482 as a related
jira but does not seem to have mentioned in the previous comment.
- why do we need so many profiles: skipUTsOnSkipTests and
skipUTsOnMavenTestSkip ? This seems like a bad design.
- Assuming that the skip tests are needed because tests are not working in
some envs, having that be done in a separate jira allows the patch to be
removed once all issues are fixed. Doing everything in this one jira makes the
revert complex.
> Tez UI: Make the build work in IBM PPC
> --------------------------------------
>
> Key: TEZ-3470
> URL: https://issues.apache.org/jira/browse/TEZ-3470
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.8.3
> Reporter: Sreenath Somarajapuram
> Assignee: Sreenath Somarajapuram
> Labels: TezUI
> Attachments: TEZ-3470.1.patch, TEZ-3470.2.patch, TEZ-3470.3.patch,
> TEZ-3470.wip.1.patch
>
>
> Current versions of frontend-maven-plugin, node & npm used by the build is
> not functioning as expected in IBM PPC. Following version works, and the
> build must be changed to used the same in a PPC.
> - frontend-maven-plugin : v1.1
> - node : v5.7.0
> - npm : 3.6.0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
