[ 
https://issues.apache.org/jira/browse/TEZ-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857296#comment-15857296
 ] 

Siddharth Seth commented on TEZ-3267:
-------------------------------------

Mostly looks good.
- Instead of passing the queue name in as a parameter to each dag - this can be 
made available via AppContext - and accessed in DAGImpl. (The queue name does 
not change per dag). Should eliminate a lot of the test ctor changes. In fact 
it can be logged from the AppMaster itself, which is where the relevant event 
is being generated, so no changes to DAGImpl.
- I'm not sure we should put this into a primary filter just yet. It's possible 
to receive a "null" queue name - the app gets submitted to whatever the default 
queue is on the cluster. Unless we know this (the TODO YARN change) - we'll end 
up not publishing data for such cases. (Search for 'default' will be incorrect 
from the UI).

Another way to get the queue name, which I don't particularly like, is to send 
a queue name field with the DagSubmission The client has access to the queue 
name from YARN via ApplicationReport. This will be more accurate, and I expect 
the change will be harmless. This value will stay unchanged through the life of 
the App (unless someone uses the YARN move queue feature). Think we should set 
the submissionQueue always though. Thoughts?






> Allow dag to be searchable by queue name.
> -----------------------------------------
>
>                 Key: TEZ-3267
>                 URL: https://issues.apache.org/jira/browse/TEZ-3267
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Harish Jaiprakash
>            Assignee: Harish Jaiprakash
>         Attachments: TEZ-3267.0.patch, TEZ-3267.1.patch, TEZ-3267.2.patch, 
> TEZ-3267.3.patch, TEZ-3267.4.patch, TEZ-3267.5.patch, TEZ-3267.6.patch, 
> TEZ-3267.7.patch, TEZ-3267.8.patch
>
>
> Use submission queue info from YARN to update ATS data for dag to allow 
> searches by queue name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to