[
https://issues.apache.org/jira/browse/TEZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030317#comment-16030317
]
TezQA commented on TEZ-3747:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12870399/TEZ-3747.001.patch
against master revision 241a7fa.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2489//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2489//console
This message is automatically generated.
> TezConstants.TEZ_SHUFFLE_HANDLER_SERVICE_ID is referenced in Hive
> -----------------------------------------------------------------
>
> Key: TEZ-3747
> URL: https://issues.apache.org/jira/browse/TEZ-3747
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Kuhu Shukla
> Priority: Minor
> Attachments: TEZ-3747.001.patch
>
>
> TezConstants is marked as private.
> However, {{TezConstants.TEZ_SHUFFLE_HANDLER_SERVICE_ID}} is referenced in
> Hive
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java#L219
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java#L172
> Post TEZ-3334 merge, this would throw "cannot find symbol" exception during
> compilation.
> May be easier option would be add
> {{TezConstants.TEZ_SHUFFLE_HANDLER_SERVICE_ID}} and reference it in
> {{TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT}} as hive
> supports multiple versions of tez.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
