[ 
https://issues.apache.org/jira/browse/TEZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030674#comment-16030674
 ] 

Rajesh Balamohan commented on TEZ-3747:
---------------------------------------

Yes, that needs to be fixed in hive later.

LGTM. +1. Thanks [~kshukla]. 

> TezConstants.TEZ_SHUFFLE_HANDLER_SERVICE_ID is referenced in Hive
> -----------------------------------------------------------------
>
>                 Key: TEZ-3747
>                 URL: https://issues.apache.org/jira/browse/TEZ-3747
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Kuhu Shukla
>            Priority: Minor
>         Attachments: TEZ-3747.001.patch
>
>
> TezConstants is marked as private. 
> However,  {{TezConstants.TEZ_SHUFFLE_HANDLER_SERVICE_ID}} is referenced in 
> Hive
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java#L219
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java#L172
> Post TEZ-3334 merge, this would throw "cannot find symbol" exception during 
> compilation. 
> May be easier option would be add 
> {{TezConstants.TEZ_SHUFFLE_HANDLER_SERVICE_ID}} and reference it in 
> {{TezConfiguration.TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT}} as hive 
> supports multiple versions of tez.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to