[ 
https://issues.apache.org/jira/browse/TEZ-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199329#comment-16199329
 ] 

Kuhu Shukla commented on TEZ-3849:
----------------------------------

Thank you [~jacobtolar] for the patch. The wrapped Iterator seems good but 
wondering if we can either just add a hasNext() to the original Iterator 
(although that would mean adding it in all implementations) or just 
reinitialize kvIter back to {{kvIter = merger.filter(i);}} in the case of 
combiner != null. Thoughts?

> Combiner+PipelinedSorter silently drops records
> -----------------------------------------------
>
>                 Key: TEZ-3849
>                 URL: https://issues.apache.org/jira/browse/TEZ-3849
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jacob Tolar
>            Assignee: Jacob Tolar
>         Attachments: TEZ-3849.1.patch, TEZ-3849.2.patch
>
>
> This bug was introduced in 
> https://github.com/apache/tez/commit/a47e8fcbea5eeab5a7cf812271d329524cc02dba?diff=split
>  
> when combiner != null, the change in this commit passes kvIter with next() 
> having already been called. This ends up (silently) dropping the first record 
> in the partition. 
> Will submit PR and attach patch. [~jeagles], not sure if this is the way you 
> want to fix or not but it does fix my tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to