[
https://issues.apache.org/jira/browse/TEZ-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207534#comment-16207534
]
Kuhu Shukla commented on TEZ-3849:
----------------------------------
Thanks for the updated patch. Just super minor nits .
PipelinedSorter line 1282 :
We can take out the comment.
Also some whitespaces at line 471, 477 in TestPipelinedSorter.
{code}
// invoked by caller
// writer.close();
{code}
This can be removed too from the test.
Rest all looks good!
> Combiner+PipelinedSorter silently drops records
> -----------------------------------------------
>
> Key: TEZ-3849
> URL: https://issues.apache.org/jira/browse/TEZ-3849
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jacob Tolar
> Assignee: Jacob Tolar
> Attachments: TEZ-3849.1.patch, TEZ-3849.2.patch, TEZ-3849.3.patch,
> TEZ-3849.4.patch, TEZ-3849.5.patch
>
>
> This bug was introduced in
> https://github.com/apache/tez/commit/a47e8fcbea5eeab5a7cf812271d329524cc02dba?diff=split
>
> when combiner != null, the change in this commit passes kvIter with next()
> having already been called. This ends up (silently) dropping the first record
> in the partition.
> Will submit PR and attach patch. [~jeagles], not sure if this is the way you
> want to fix or not but it does fix my tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
