[
https://issues.apache.org/jira/browse/TEZ-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208220#comment-16208220
]
TezQA commented on TEZ-3849:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12892660/TEZ-3849.6.patch
against master revision f760ad3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in :
org.apache.tez.test.TestRecovery
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2667//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2667//console
This message is automatically generated.
> Combiner+PipelinedSorter silently drops records
> -----------------------------------------------
>
> Key: TEZ-3849
> URL: https://issues.apache.org/jira/browse/TEZ-3849
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jacob Tolar
> Assignee: Jacob Tolar
> Attachments: TEZ-3849.1.patch, TEZ-3849.2.patch, TEZ-3849.3.patch,
> TEZ-3849.4.patch, TEZ-3849.5.patch, TEZ-3849.6.patch
>
>
> This bug was introduced in
> https://github.com/apache/tez/commit/a47e8fcbea5eeab5a7cf812271d329524cc02dba?diff=split
>
> when combiner != null, the change in this commit passes kvIter with next()
> having already been called. This ends up (silently) dropping the first record
> in the partition.
> Will submit PR and attach patch. [~jeagles], not sure if this is the way you
> want to fix or not but it does fix my tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
