[ 
https://issues.apache.org/jira/browse/TEZ-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526319#comment-16526319
 ] 

Jason Lowe commented on TEZ-3962:
---------------------------------

Thanks for the patch!

Why does this patch change the semantics to translate IOExceptions to 
RuntimeExceptions?  That does not seem desirable and is unrelated to the 
reported issue.  I don't see a need to add a catch clause here, as there wasn't 
one before.  Is there another issue being fixed at the same time?

> Configuration decode leaks an Inflater object
> ---------------------------------------------
>
>                 Key: TEZ-3962
>                 URL: https://issues.apache.org/jira/browse/TEZ-3962
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.2, 0.10.0
>            Reporter: Gopal V
>            Assignee: Eric Wohlstadter
>            Priority: Major
>         Attachments: TEZ-3962.1.patch
>
>
> {code}
> public static Configuration createConfFromByteString(ByteString byteString) 
> throws IOException {
> ...
>     InflaterInputStream uncompressIs = new 
> InflaterInputStream(byteString.newInput());
>     DAGProtos.ConfigurationProto confProto = 
> DAGProtos.ConfigurationProto.parseFrom(uncompressIs);
> {code}
> InflaterInputStream is never closed, this will get eventually collected - but 
> the off-heap buffers for Inflater leaks temporarily.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to