[ 
https://issues.apache.org/jira/browse/TEZ-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526661#comment-16526661
 ] 

Eric Wohlstadter commented on TEZ-3962:
---------------------------------------

[~jlowe]

Thanks for the review. I see what you mean. The new code introduces a new 
failure mode since now {{close}} may fail. But we can just let an exception 
from {{close}} be propagated without any specific intervention. 

> Configuration decode leaks an Inflater object
> ---------------------------------------------
>
>                 Key: TEZ-3962
>                 URL: https://issues.apache.org/jira/browse/TEZ-3962
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.2, 0.10.0
>            Reporter: Gopal V
>            Assignee: Eric Wohlstadter
>            Priority: Major
>         Attachments: TEZ-3962.1.patch
>
>
> {code}
> public static Configuration createConfFromByteString(ByteString byteString) 
> throws IOException {
> ...
>     InflaterInputStream uncompressIs = new 
> InflaterInputStream(byteString.newInput());
>     DAGProtos.ConfigurationProto confProto = 
> DAGProtos.ConfigurationProto.parseFrom(uncompressIs);
> {code}
> InflaterInputStream is never closed, this will get eventually collected - but 
> the off-heap buffers for Inflater leaks temporarily.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to