[jira] [Commented] (TEZ-4131) Reduce apache commons collections direct dependencies

[Jonathan Turner Eagles (Jira)]

    [ 
https://issues.apache.org/jira/browse/TEZ-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059096#comment-17059096
 ] 

Jonathan Turner Eagles commented on TEZ-4131:
---------------------------------------------

Adding
{code}
        <compilerArgument>-Xlint:all</compilerArgument>
        <showWarnings>true</showWarnings>
        <showDeprecation>true</showDeprecation>
{code}

to pom.xml maven-compiler-plugin:configuration will show what the javac 
warnings are.

{noformat}
[WARNING] 
tez/tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:[74,17]
 found raw type: org.apache.commons.collections4.BidiMap
  missing type arguments for generic class 
org.apache.commons.collections4.BidiMap<K,V>
[WARNING] 
tez/tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:[92,31]
 found raw type: org.apache.commons.collections4.bidimap.DualHashBidiMap
  missing type arguments for generic class 
org.apache.commons.collections4.bidimap.DualHashBidiMap<K,V>
[WARNING] 
tez/tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:[161,32]
 unchecked call to put(K,V) as a member of the raw type 
org.apache.commons.collections4.BidiMap
[WARNING] 
tez/tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:[610,16]
 found raw type: java.util.Map
  missing type arguments for generic class java.util.Map<K,V>
{noformat}



> Reduce apache commons collections direct dependencies
> -----------------------------------------------------
>
>                 Key: TEZ-4131
>                 URL: https://issues.apache.org/jira/browse/TEZ-4131
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jonathan Turner Eagles
>            Assignee: zhangbutao
>            Priority: Minor
>         Attachments: TEZ-4131.1.patch, TEZ-4131.2.patch
>
>
> Tez has limited use of direct apache commons collects, but ships both commons 
> collections 3 and 4
> {noformat:title=Dependent jars}
> commons-collections-3.2.2.jar
> commons-collections4-4.1.jar
> {noformat}
> {noformat:title=Usage}
> $ git grep org.apache.commons.coll
> tez-api/src/main/java/org/apache/tez/dag/api/DAG.java:import 
> org.apache.commons.collections4.BidiMap;
> tez-api/src/main/java/org/apache/tez/dag/api/DAG.java:import 
> org.apache.commons.collections4.bidimap.DualLinkedHashBidiMap;
> tez-dag/src/main/java/org/apache/tez/dag/app/TaskCommunicatorManager.java:import
>  org.apache.commons.collections4.ListUtils;
> tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapred/MRCounters.java:import
>  org.apache.commons.collections.IteratorUtils;
> tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:import
>  org.apache.commons.collections.BidiMap;
> tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:import
>  org.apache.commons.collections.bidimap.DualHashBidiMap;
> {noformat}
> Likely, we can either converge on either commons collections 3 or 4 or remove 
> them all together if a viable substitute for the bidirectional maps can be 
> found.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)