[
https://issues.apache.org/jira/browse/TEZ-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059708#comment-17059708
]
TezQA commented on TEZ-4131:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 4m
6s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
16s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
57s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
26s{color} | {color:blue} branch/tez-dist no findbugs output file
(findbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
54s{color} | {color:red} root in master has 2 extant findbugs warnings. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
49s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 27s{color} | {color:orange} tez-plugins/tez-history-parser: The patch
generated 2 new + 30 unchanged - 0 fixed = 32 total (was 30) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 49s{color} | {color:orange} root: The patch generated 2 new + 48 unchanged -
0 fixed = 50 total (was 48) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
27s{color} | {color:blue} tez-dist has no data from findbugs {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
27s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
25s{color} | {color:green} tez-history-parser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} tez-dist in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 65m
25s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
0s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}122m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 base:
https://builds.apache.org/job/PreCommit-TEZ-Build/314/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4131 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12996765/TEZ-4131.3.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile shellcheck
shelldocs spotbugs findbugs checkstyle |
| uname | Linux c50f07516d86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 240f80b |
| Default Java | 1.8.0_242 |
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/314/artifact/out/branch-findbugs-root-warnings.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/314/artifact/out/diff-checkstyle-tez-plugins_tez-history-parser.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/314/artifact/out/diff-checkstyle-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/314/testReport/ |
| Max. process+thread count | 1697 (vs. ulimit of 5500) |
| modules | C: tez-mapreduce tez-plugins/tez-history-parser tez-dist . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/314/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.3.7 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> Reduce apache commons collections direct dependencies
> -----------------------------------------------------
>
> Key: TEZ-4131
> URL: https://issues.apache.org/jira/browse/TEZ-4131
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Jonathan Turner Eagles
> Assignee: zhangbutao
> Priority: Minor
> Attachments: TEZ-4131.1.patch, TEZ-4131.2.patch, TEZ-4131.3.patch
>
>
> Tez has limited use of direct apache commons collects, but ships both commons
> collections 3 and 4
> {noformat:title=Dependent jars}
> commons-collections-3.2.2.jar
> commons-collections4-4.1.jar
> {noformat}
> {noformat:title=Usage}
> $ git grep org.apache.commons.coll
> tez-api/src/main/java/org/apache/tez/dag/api/DAG.java:import
> org.apache.commons.collections4.BidiMap;
> tez-api/src/main/java/org/apache/tez/dag/api/DAG.java:import
> org.apache.commons.collections4.bidimap.DualLinkedHashBidiMap;
> tez-dag/src/main/java/org/apache/tez/dag/app/TaskCommunicatorManager.java:import
> org.apache.commons.collections4.ListUtils;
> tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/mapred/MRCounters.java:import
> org.apache.commons.collections.IteratorUtils;
> tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:import
> org.apache.commons.collections.BidiMap;
> tez-plugins/tez-history-parser/src/main/java/org/apache/tez/history/parser/datamodel/DagInfo.java:import
> org.apache.commons.collections.bidimap.DualHashBidiMap;
> {noformat}
> Likely, we can either converge on either commons collections 3 or 4 or remove
> them all together if a viable substitute for the bidirectional maps can be
> found.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
