[
https://issues.apache.org/jira/browse/TEZ-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063977#comment-17063977
]
TezQA commented on TEZ-4105:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 5m
14s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} tez-tools/analyzers/job-analyzer in master has 4
extant findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 5m
10s{color} | {color:red} root in master has 2 extant findbugs warnings. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} tez-plugins_tez-history-parser generated 2 new + 2 unchanged - 0
fixed = 4 total (was 2) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 20s{color}
| {color:red} root generated 2 new + 40 unchanged - 0 fixed = 42 total (was 40)
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} tez-common: The patch generated 0 new + 2 unchanged
- 1 fixed = 2 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} The patch passed checkstyle in tez-dag {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 17s{color} | {color:orange} tez-plugins/tez-protobuf-history-plugin: The
patch generated 61 new + 4 unchanged - 0 fixed = 65 total (was 4) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 18s{color} | {color:orange} tez-plugins/tez-history-parser: The patch
generated 7 new + 63 unchanged - 2 fixed = 70 total (was 65) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 16s{color} | {color:orange} tez-tools/analyzers/job-analyzer: The patch
generated 1 new + 23 unchanged - 0 fixed = 24 total (was 23) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 46s{color} | {color:orange} root: The patch generated 69 new + 155 unchanged
- 3 fixed = 224 total (was 158) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
42s{color} | {color:red} tez-tools/analyzers/job-analyzer generated 1 new + 4
unchanged - 0 fixed = 5 total (was 4) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 5m
24s{color} | {color:red} root generated 1 new + 2 unchanged - 0 fixed = 3 total
(was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} tez-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 59s{color}
| {color:red} tez-dag in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 26s{color}
| {color:red} tez-protobuf-history-plugin in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
12s{color} | {color:green} tez-history-parser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
28s{color} | {color:green} job-analyzer in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 32s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
39s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 73m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-tools/analyzers/job-analyzer |
| | Possible null pointer dereference in
org.apache.tez.analyzer.plugins.TezAnalyzerBase.collectFilesForDagId(File,
String) due to return value of called method Method invoked at
TezAnalyzerBase.java:org.apache.tez.analyzer.plugins.TezAnalyzerBase.collectFilesForDagId(File,
String) due to return value of called method Method invoked at
TezAnalyzerBase.java:[line 228] |
| FindBugs | module:root |
| | Possible null pointer dereference in
org.apache.tez.analyzer.plugins.TezAnalyzerBase.collectFilesForDagId(File,
String) due to return value of called method Method invoked at
TezAnalyzerBase.java:org.apache.tez.analyzer.plugins.TezAnalyzerBase.collectFilesForDagId(File,
String) due to return value of called method Method invoked at
TezAnalyzerBase.java:[line 228] |
| Failed junit tests | tez.dag.app.TestSpeculation |
| | tez.dag.history.logging.proto.TestHistoryEventProtoConverter |
| | tez.dag.app.TestSpeculation |
| | tez.dag.history.logging.proto.TestHistoryEventProtoConverter |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 base:
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4105 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12997324/TEZ-4105.02.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs
findbugs checkstyle |
| uname | Linux b30dac0dd634 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / b5b432b |
| Default Java | 1.8.0_242 |
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/branch-findbugs-tez-tools_analyzers_job-analyzer-warnings.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/branch-findbugs-root-warnings.html
|
| javac |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/diff-compile-javac-tez-plugins_tez-history-parser.txt
|
| javac |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/diff-checkstyle-tez-plugins_tez-protobuf-history-plugin.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/diff-checkstyle-tez-plugins_tez-history-parser.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/diff-checkstyle-root.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/new-findbugs-tez-tools_analyzers_job-analyzer.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/new-findbugs-root.html
|
| unit |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/patch-unit-tez-dag.txt
|
| unit |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/patch-unit-tez-plugins_tez-protobuf-history-plugin.txt
|
| unit |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/testReport/ |
| Max. process+thread count | 798 (vs. ulimit of 5500) |
| modules | C: tez-common tez-dag tez-plugins/tez-protobuf-history-plugin
tez-plugins/tez-history-parser tez-tools/analyzers/job-analyzer . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/322/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> Tez job-analyzer tool to support proto logging history
> ------------------------------------------------------
>
> Key: TEZ-4105
> URL: https://issues.apache.org/jira/browse/TEZ-4105
> Project: Apache Tez
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Attachments: TEZ-4105.01.patch, TEZ-4105.02.patch,
> dag_1583980529217_0000_18_1, dag_1583980529217_0000_18_1_1
>
>
> Currently analyzers in tez-tools can only work with output of ats (zipped
> json files) and simple history logging (plain text json file) files. It would
> be nice to have a parser that can create the needed info for analyzers from a
> dag protobuf file. In order to achieve this, we need at least a converter
> which can convert HistoryProtoEvent instances to a format which can be read
> by TezAnalyzerBase (+ a new parser is needed, similarly to
> SimpleHistoryParser)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)