[ 
https://issues.apache.org/jira/browse/TEZ-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082697#comment-17082697
 ] 

Jonathan Turner Eagles commented on TEZ-4105:
---------------------------------------------

Why was the start time added to the VertexFinishedEvent as it is already part 
of the VertexStartedEvent and should be available?

tez-dag/src/main/java/org/apache/tez/dag/history/logging/impl/HistoryEventJsonConversion.java

 

Also the TezDAGID changes seem unnecessary.

 

I notice dependencies added to the protobuf-history-plugin test-jar. I might be 
reading it incorrectly, but that can be an indication that a test class should 
be promoted to a Utility class.

> Tez job-analyzer tool to support proto logging history
> ------------------------------------------------------
>
>                 Key: TEZ-4105
>                 URL: https://issues.apache.org/jira/browse/TEZ-4105
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-4105.01.patch, TEZ-4105.02.patch, TEZ-4105.03.patch, 
> TEZ-4105.04.patch, TEZ-4105.05.patch, TEZ-4105.06.patch, TEZ-4105.07.patch, 
> TEZ-4105.08.patch, TEZ-4105.09.patch, dag_1583980529217_0000_18_1, 
> dag_1583980529217_0000_18_1_1
>
>
> Currently analyzers in tez-tools can only work with output of ats (zipped 
> json files) and simple history logging (plain text json file) files. It would 
> be nice to have a parser that can create the needed info for analyzers from a 
> dag protobuf file. In order to achieve this, we need at least a converter 
> which can convert HistoryProtoEvent instances to a format which can be read 
> by TezAnalyzerBase (+ a new parser is needed, similarly to 
> SimpleHistoryParser)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to