[
https://issues.apache.org/jira/browse/TEZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278773#comment-17278773
]
Tez CI commented on TEZ-4281:
-----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
40s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 19s{color} | {color:orange} tez-dag: The patch generated 3 new + 133
unchanged - 0 fixed = 136 total (was 133) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
10s{color} | {color:red} tez-dag generated 2 new + 0 unchanged - 0 fixed = 2
total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
18s{color} | {color:green} tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 26s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-dag |
| | org.apache.tez.dag.app.dag.impl.DAGImpl.getLogDirs() may expose internal
representation by returning DAGImpl.logDirs At DAGImpl.java:by returning
DAGImpl.logDirs At DAGImpl.java:[line 2522] |
| | org.apache.tez.dag.app.dag.impl.DAGImpl.setLogDirs(String[]) may expose
internal representation by storing an externally mutable object into
DAGImpl.logDirs At DAGImpl.java:by storing an externally mutable object into
DAGImpl.logDirs At DAGImpl.java:[line 2526] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/tez/pull/102 |
| JIRA Issue | TEZ-4281 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
checkstyle compile |
| uname | Linux dc8bd0507f3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 73bcabd2b |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| checkstyle |
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/2/artifact/out/diff-checkstyle-tez-dag.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/2/artifact/out/new-findbugs-tez-dag.html
|
| Test Results |
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/2/testReport/ |
| Max. process+thread count | 188 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output |
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/2/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> dag_*_priority.dot files should go into a valid log directory
> -------------------------------------------------------------
>
> Key: TEZ-4281
> URL: https://issues.apache.org/jira/browse/TEZ-4281
> Project: Apache Tez
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> TEZ-4229 handled the case of e.g. tez-local-cache folders and tez-conf.pb
> files, but seems like the config ("tez.local.cache.root.folder") has no
> effect on dag_*_priority.dot files.
> I did the same hive unit test as on TEZ-4229 and I found that there are still
> lots of files there (that somehow I missed last time):
> {code}
> itests/hive-unit/dag_1612431668191_0001_10_priority.dot
> itests/hive-unit/dag_1612431668191_0001_11_priority.dot
> itests/hive-unit/dag_1612431668191_0001_12_priority.dot
> itests/hive-unit/dag_1612431668191_0001_13_priority.dot
> itests/hive-unit/dag_1612431668191_0001_14_priority.dot
> itests/hive-unit/dag_1612431668191_0001_1_priority.dot
> itests/hive-unit/dag_1612431668191_0001_2_priority.dot
> itests/hive-unit/dag_1612431668191_0001_3_priority.dot
> itests/hive-unit/dag_1612431668191_0001_4_priority.dot
> itests/hive-unit/dag_1612431668191_0001_5_priority.dot
> itests/hive-unit/dag_1612431668191_0001_6_priority.dot
> itests/hive-unit/dag_1612431668191_0001_7_priority.dot
> itests/hive-unit/dag_1612431668191_0001_8_priority.dot
> {code}
> sometimes I also catch another resources on watch git status, like:
> {code}
> itests/hive-unit/hive-exec-3.1.3000.7.1.7.0-SNAPSHOT-170a3a6a1dffe
> {code}
> UPDATE: it turned out that the problem is that Utils.generateDAGVizFile has a
> 3 parameters version without having to supply logDirs, and resolves to env
> variable. This is not sufficient as the user has to take care of that. With a
> simple change, we can propagate logDirs from DAGAppMaster through DagImpl to
> this codepath.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
