[ 
https://issues.apache.org/jira/browse/TEZ-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281343#comment-17281343
 ] 

Tez CI commented on TEZ-4281:
-----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  1m 
37s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 18s{color} | {color:orange} tez-dag: The patch generated 1 new + 133 
unchanged - 0 fixed = 134 total (was 133) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
21s{color} | {color:green} tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 24s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/7/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/tez/pull/102 |
| JIRA Issue | TEZ-4281 |
| Optional Tests | dupname asflicense xml javac javadoc unit spotbugs findbugs 
checkstyle compile |
| uname | Linux c4f2d1beb16a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / cd0548631 |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| checkstyle | 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/7/artifact/out/diff-checkstyle-tez-dag.txt
 |
|  Test Results | 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/7/testReport/ |
| Max. process+thread count | 190 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-102/7/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> dag_*_priority.dot files should go into a valid log directory
> -------------------------------------------------------------
>
>                 Key: TEZ-4281
>                 URL: https://issues.apache.org/jira/browse/TEZ-4281
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> TEZ-4229 handled the case of e.g. tez-local-cache folders and tez-conf.pb 
> files, but seems like the config ("tez.local.cache.root.folder") has no 
> effect on dag_*_priority.dot files.
> I did the same hive unit test as on TEZ-4229 and I found that there are still 
> lots of files there (that somehow I missed last time):
> {code}
>         itests/hive-unit/dag_1612431668191_0001_10_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_11_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_12_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_13_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_14_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_1_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_2_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_3_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_4_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_5_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_6_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_7_priority.dot
>         itests/hive-unit/dag_1612431668191_0001_8_priority.dot
> {code}
> sometimes I also catch another resources on watch git status, like:
> {code}
>         itests/hive-unit/hive-exec-3.1.3000.7.1.7.0-SNAPSHOT-170a3a6a1dffe
> {code}
> UPDATE: it turned out that the problem is that Utils.generateDAGVizFile has a 
> 3 parameters version without having to supply logDirs, and resolves to env 
> variable. This is not sufficient as the user has to take care of that. With a 
> simple change, we can propagate logDirs from DAGAppMaster through DagImpl to 
> this codepath.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to