[ 
https://issues.apache.org/jira/browse/TEZ-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

László Bodor updated TEZ-4290:
------------------------------
    Description: 
Given these improvement ideas: 
https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51
Dockerfile changes could be easily tested, becuase it can be build locally (as 
discovered on TEZ-4283):
{code}
docker build -f ./build-tools/docker/Dockerfile ./build-tools/docker/
{code}

Moreover, it's applied on PR level, so a full precommit test (including all 
modules) could let us validate the correctness of the image changes.

So, I'm suspecting that Dockerfile changes can come in advance, before 
introducing Jenkinsfile, which is a bit harder to test (I guess).

  was:
Given these improvements: 
https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51
Dockerfile changes could be easily tested becuase it can be build locally (as 
discovered on TEZ-4283):
{code}
docker build -f ./build-tools/docker/Dockerfile ./build-tools/docker/
{code}

Moreover it's applied on PR level, so a full precommit test (all modules) could 
let us validate the correctness of the image changes.


> Dockerfile improvements
> -----------------------
>
>                 Key: TEZ-4290
>                 URL: https://issues.apache.org/jira/browse/TEZ-4290
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>
> Given these improvement ideas: 
> https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51
> Dockerfile changes could be easily tested, becuase it can be build locally 
> (as discovered on TEZ-4283):
> {code}
> docker build -f ./build-tools/docker/Dockerfile ./build-tools/docker/
> {code}
> Moreover, it's applied on PR level, so a full precommit test (including all 
> modules) could let us validate the correctness of the image changes.
> So, I'm suspecting that Dockerfile changes can come in advance, before 
> introducing Jenkinsfile, which is a bit harder to test (I guess).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to