[
https://issues.apache.org/jira/browse/TEZ-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated TEZ-4290:
------------------------------
Description:
Given these improvement ideas:
https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51
thanks [~aw]
Dockerfile changes could be easily tested, because it can be build locally (as
discovered on TEZ-4283):
{code}
docker build -f ./build-tools/docker/Dockerfile ./build-tools/docker/
{code}
Moreover, it's applied on PR level, so a full precommit test (including all
modules) could let us validate the correctness of the image changes.
So, I'm suspecting that Dockerfile changes can come in advance, before
introducing Jenkinsfile, which is a bit harder to test (I guess).
according to [~aw]'s comments:
{code}
- Update to an image that won't be unsupported in a year
- Remove a bunch of stuff that Tez doesn't use
- Add support for a bunch of stuff that Yetus needs to test everything
(however, keeping FindBugs over SpotBugs)
- Make it Docker BuildKit compatible to make it build in parallel
- Support both OpenJDK 8 and OpenJDK 11
- Switch to python3 because python2 is effectively dead in January with pip
changes
- Remove the interactive bits of the Dockerfile since nothing appears to be
using them
{code}
was:
Given these improvement ideas:
https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51
thanks [~aw]
Dockerfile changes could be easily tested, becuase it can be build locally (as
discovered on TEZ-4283):
{code}
docker build -f ./build-tools/docker/Dockerfile ./build-tools/docker/
{code}
Moreover, it's applied on PR level, so a full precommit test (including all
modules) could let us validate the correctness of the image changes.
So, I'm suspecting that Dockerfile changes can come in advance, before
introducing Jenkinsfile, which is a bit harder to test (I guess).
according to [~aw]'s comments:
{code}
- Update to an image that won't be unsupported in a year
- Remove a bunch of stuff that Tez doesn't use
- Add support for a bunch of stuff that Yetus needs to test everything
(however, keeping FindBugs over SpotBugs)
- Make it Docker BuildKit compatible to make it build in parallel
- Support both OpenJDK 8 and OpenJDK 11
- Switch to python3 because python2 is effectively dead in January with pip
changes
- Remove the interactive bits of the Dockerfile since nothing appears to be
using them
{code}
> Dockerfile improvements
> -----------------------
>
> Key: TEZ-4290
> URL: https://issues.apache.org/jira/browse/TEZ-4290
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Fix For: 0.10.1, 0.9.3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Given these improvement ideas:
> https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51
> thanks [~aw]
> Dockerfile changes could be easily tested, because it can be build locally
> (as discovered on TEZ-4283):
> {code}
> docker build -f ./build-tools/docker/Dockerfile ./build-tools/docker/
> {code}
> Moreover, it's applied on PR level, so a full precommit test (including all
> modules) could let us validate the correctness of the image changes.
> So, I'm suspecting that Dockerfile changes can come in advance, before
> introducing Jenkinsfile, which is a bit harder to test (I guess).
> according to [~aw]'s comments:
> {code}
> - Update to an image that won't be unsupported in a year
> - Remove a bunch of stuff that Tez doesn't use
> - Add support for a bunch of stuff that Yetus needs to test everything
> (however, keeping FindBugs over SpotBugs)
> - Make it Docker BuildKit compatible to make it build in parallel
> - Support both OpenJDK 8 and OpenJDK 11
> - Switch to python3 because python2 is effectively dead in January with pip
> changes
> - Remove the interactive bits of the Dockerfile since nothing appears to be
> using them
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
