abstractdog edited a comment on pull request #162: URL: https://github.com/apache/tez/pull/162#issuecomment-1006084344
let me give the background of this change: it was created exactly because of the same inconsistent sync alerts in TEZ-4347 (which I'm about to finish soon too), just because in TEZ-4347 I was accessing some fields, that I don't really worried about from synchronization point of view, e.g. webUIService (alert is [here](https://github.com/apache/tez/pull/160#issuecomment-968354475)), but it's accessed from serviceInit too, which doesn't need to be synchronized according to comments this means two ways to solve this: [1] make every access to every variable synchronized which is accessed from synchronized serviceInit [2] consider removing synchronized from serviceInit if possible [1] doesn't make sense to me, as serviceInit itself is not supposed to be synchronized [2] I want to go this way, even if it gave an inconsistent sync alert (that needs to be checked), but in the opposite way as I saw in TEZ-4347, so here I need to revise if every field accessed from serviceInit should be really accessed synchronized every time so my point is, the goal here is not performance, but going for [2] instead of [1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
