abstractdog edited a comment on pull request #162: URL: https://github.com/apache/tez/pull/162#issuecomment-1014848520
double-checked: AbstractService lifecycle methods are guarded with a lock since YARN-530 (which introduced a strict and robust lifecycle) that's why serviceInit, serviceStart, serviceStop is not supposed to be guarded in AbstractService subclasses I also found that this change has let me remove lots of inconsistent sync warnings from findbugs-exclude.xml config (basically: these 3 methods touch a lot of DAGAppMaster fields, by which findbugs thinks that they needs synchronized access during the whole DAGAppMaster lifecycle) YARN-530 + MAPREDUCE-5298 introduced similar changes to [MrAppMaster](https://github.com/apache/hadoop/blame/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
