ayushtkn commented on code in PR #309:
URL: https://github.com/apache/tez/pull/309#discussion_r1342874429
##########
tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java:
##########
@@ -336,8 +328,13 @@ public static FileSystem
ensureStagingDirExists(Configuration conf,
UserGroupInformation ugi = UserGroupInformation.getLoginUser();
realUser = ugi.getShortUserName();
currentUser = UserGroupInformation.getCurrentUser().getShortUserName();
- if (fs.exists(stagingArea)) {
- FileStatus fsStatus = fs.getFileStatus(stagingArea);
+ FileStatus fsStatus = null;
+ try {
+ fsStatus = fs.getFileStatus(stagingArea);
+ } catch (FileNotFoundException fnf) {
+ // Ignore
Review Comment:
We can't return, there is an else block below if fsStatus is null
```
else {
TezCommonUtils.mkDirForAM(fs, stagingArea);
}
```
##########
tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java:
##########
@@ -659,11 +661,11 @@ public DAGRecoveryData parseRecoveryData() throws
IOException {
List<Path> summaryFiles = getSummaryFiles();
LOG.debug("SummaryFile size:" + summaryFiles.size());
for (Path summaryFile : summaryFiles) {
- FileStatus summaryFileStatus = recoveryFS.getFileStatus(summaryFile);
- LOG.info("Parsing summary file"
- + ", path=" + summaryFile.toString()
- + ", len=" + summaryFileStatus.getLen()
- + ", lastModTime=" + summaryFileStatus.getModificationTime());
+ if (LOG.isDebugEnabled()) {
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
