abstractdog commented on code in PR #309:
URL: https://github.com/apache/tez/pull/309#discussion_r1343574149
##########
tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java:
##########
@@ -741,12 +743,10 @@ public DAGRecoveryData parseRecoveryData() throws
IOException {
+ lastRecoveryFile);
break;
}
- FileStatus fileStatus = recoveryFS.getFileStatus(dagRecoveryFile);
lastRecoveryFile = dagRecoveryFile;
- LOG.info("Trying to recover dag from recovery file"
- + ", dagId=" + lastInProgressDAG.toString()
- + ", dagRecoveryFile=" + dagRecoveryFile
- + ", len=" + fileStatus.getLen());
+ LOG.info("Trying to recover dag from recovery file, dagId={},
dagRecoveryFile={}", lastInProgressDAG,
Review Comment:
we about leaving the useful info on DEBUG level, but in that case, we can
log the full FileStatus, like
```
LOG.info("Trying to recover dag from recovery file, dagId={},
dagRecoveryFile={}", lastInProgressDAG,
dagRecoveryFile);
if (LOG.isDebugEnabled()) {
// extra RPC call
FileStatus fileStatus = recoveryFS.getFileStatus(dagRecoveryFile);
LOG.debug("Recovery file details: {}", fileStatus);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
