Aggarwal-Raghav commented on PR #444: URL: https://github.com/apache/tez/pull/444#issuecomment-3562310199
@maheshrajus @abstractdog , it seems that the pylint is not working in yetus based on [/branch-pylint-stderr.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-444/1/artifact/out/branch-pylint-stderr.txt) , As i ran the pylint in local, there are lot of issues unrelated to the change. I can surely check/fix them along with shellcheck, blanks, asfheader etc. Also, 1 major flaw in python scripts are, tabs are not converted to spaces and has un-even indentation. ``` Python's official style guide, PEP 8, strongly recommends using spaces for indentation, specifically four consecutive spaces per indentation level. While Python technically allows both tabs and spaces for indentation, and even disallows mixing them within the same file, spaces are the widely preferred and recommended convention ``` Scripts are old and requires some decent changes. Personally, I'm ready and committed to fix them. Will also accomodate that `pathlib` and `argparser` changes as well. I'll use both https://github.com/astral-sh/ruff and `pylint` to ensure scripts are of good quality. <img width="1463" height="396" alt="Screenshot 2025-11-21 at 3 28 10 PM" src="https://github.com/user-attachments/assets/ad52226a-4e61-4caf-8bf7-09f41e79cc10"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
