Re: [PR] TEZ-4666: Migrate tez-tools python scripts to python3 [tez]

Fri, 21 Nov 2025 02:14:02 -0800 


abstractdog commented on PR #444:
URL: https://github.com/apache/tez/pull/444#issuecomment-3562327378

   > @maheshrajus @abstractdog , it seems that the pylint is not working in 
yetus based on 
[/branch-pylint-stderr.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-444/1/artifact/out/branch-pylint-stderr.txt)
 , As i ran the pylint in local, there are lot of issues unrelated to the 
change. I can surely check/fix them along with shellcheck, blanks, asfheader 
etc.
   > 
   > Also, 1 major flaw in python scripts are, tabs are not converted to spaces 
and has un-even indentation.
   > 
   > ```
   > Python's official style guide, PEP 8, strongly recommends using spaces for 
indentation, specifically four consecutive spaces per indentation level. While 
Python technically allows both tabs and spaces for indentation, and even 
disallows mixing them within the same file, spaces are the widely preferred and 
recommended convention
   > ```
   > 
   > Scripts are old and requires some decent changes. Personally, I'm ready 
and committed to fix them. Will also accomodate that `pathlib` and `argparser` 
changes as well. I'll use both https://github.com/astral-sh/ruff and `pylint` 
to ensure scripts are of good quality.
   > 
   > <img alt="Screenshot 2025-11-21 at 3 28 10 PM" width="1463" height="396" 
src="https://private-user-images.githubusercontent.com/49618756/517321288-ad52226a-4e61-4caf-8bf7-09f41e79cc10.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjM3MjAxNDQsIm5iZiI6MTc2MzcxOTg0NCwicGF0aCI6Ii80OTYxODc1Ni81MTczMjEyODgtYWQ1MjIyNmEtNGU2MS00Y2FmLThiZjctMDlmNDFlNzljYzEwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTExMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMTIxVDEwMTA0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3YTU3MTRmYTZmMjFlNjFmMTlhY2YzNmRlYWFiM2RlMmQ0OTdhZTZiMDdjY2Q0NWMzMjgxYTY2NDhhNWQxYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vmWVjF26uSCMD857aOO0311bS8iMHHAl3YTghr3naWs";>
   
   thanks a lot for taking a look at this!
   it's fine to fix all these things in follow-up tickets, mainly because they 
tend to fall into different categories:
   
   1. python problems with our code (a lot)
   2. pylint problems that needs yetus configuration maybe


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to