abstractdog commented on code in PR #427:
URL: https://github.com/apache/tez/pull/427#discussion_r2549577799
##########
tez-api/src/main/java/org/apache/tez/client/TezClient.java:
##########
@@ -484,7 +484,9 @@ public synchronized TezClient getClient(ApplicationId
appId) throws TezException
}
private void startFrameworkClient() {
- frameworkClient = createFrameworkClient();
+ if (frameworkClient == null) {
+ frameworkClient = createFrameworkClient();
+ }
Review Comment:
right, if we want to make it idempotent, it should instead be:
```
if (frameworkClient != null) {
return;
}
frameworkClient = createFrameworkClient();
frameworkClient.init(amConfig.getTezConfiguration());
frameworkClient.start();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
