abstractdog commented on code in PR #427:
URL: https://github.com/apache/tez/pull/427#discussion_r2549593120
##########
tez-api/src/main/java/org/apache/tez/client/registry/AMRecord.java:
##########
@@ -97,37 +110,54 @@ public AMRecord(AMRecord other) {
*/
public AMRecord(ServiceRecord serviceRecord) {
this.appId =
ApplicationId.fromString(serviceRecord.get(APP_ID_RECORD_KEY));
- this.host = serviceRecord.get(HOST_RECORD_KEY);
+ this.hostName = serviceRecord.get(HOST_NAME_RECORD_KEY);
+ this.hostIp = serviceRecord.get(HOST_IP_RECORD_KEY);
this.port = Integer.parseInt(serviceRecord.get(PORT_RECORD_KEY));
- this.id = serviceRecord.get(OPAQUE_ID_KEY);
+ this.externalId = serviceRecord.get(EXTERNAL_ID_KEY);
+ this.computeName = serviceRecord.get(COMPUTE_GROUP_NAME_KEY);
}
public ApplicationId getApplicationId() {
return appId;
}
public String getHost() {
- return host;
+ return hostName;
+ }
+
+ public String getHostName() {
+ return hostName;
+ }
Review Comment:
good catch! let's have it as `getHostName` to make a clear distinction
between this and `getHostIp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
