maheshrajus commented on PR #445:
URL: https://github.com/apache/tez/pull/445#issuecomment-3579604979

   @abstractdog 
   The **RequestSize** size is coming less in test case failure scenario when 
compare to **InMemThreshold** value.
   
   INFO  [Time-limited test] impl.TestSimpleFetchedInputAllocator 
(TestSimpleFetchedInputAllocator.java:testInMemAllocationWithJvmMaxMemory(99)) 
-  **jvmMax: 1073741824**
   INFO  [Time-limited test] impl.TestSimpleFetchedInputAllocator 
(TestSimpleFetchedInputAllocator.java:testInMemAllocationWithJvmMaxMemory(107)) 
- **InMemThreshold: 107374184**
   INFO  [Time-limited test] impl.SimpleFetchedInputAllocator 
(SimpleFetchedInputAllocator.java:<init>(117)) - srcName: 
RequestedMemory=107374184, AssignedMemory=107374184, 
maxSingleShuffleLimit=107374184
   INFO  [Time-limited test] impl.TestSimpleFetchedInputAlloc¸ator 
(TestSimpleFetchedInputAllocator.java:testInMemAllocationWithJvmMaxMemory(115)) 
- **RequestSize: 42949776**
   
   here **RequestSize** should be greater than **InMemThreshold**. Then only it 
will allocate from the DISK. So it is failing in some env only. In any case we 
should put more **RequestSize** . So currently `* 10` is solving the issue.
   
   Test sample:
   ```
       // check if requestSize is greater than maxSingleShuffleLimit
       assertTrue(requestSize > inputManager.maxSingleShuffleLimit);
   
       // requestSize is greater than the maxSingleShuffleLimit, so allocation 
is from DISK
       FetchedInput fi1 = inputManager.allocate(requestSize, compressedSize, 
new InputAttemptIdentifier(1, 1));
       assertEquals(FetchedInput.Type.DISK, fi1.getType());
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to