abstractdog commented on PR #445:
URL: https://github.com/apache/tez/pull/445#issuecomment-3580685042

   I still feel the test case is shady in its current form, and I'm afraid this 
fix won't make it any clearer
   having this magic:
   ```
       long requestSize = (long) (0.4f * inMemThreshold) + 100L;
   ```
   requestSize should be greater than inMemThreshold, which is a lower bound, 
also I guess it has an upper bound constraint (jvm memory, or whatever), am I 
right to assume that?
   
   could this line be clearer to comply with those constraints and work in 
every scenario (regardless of the jvmMax)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to