abstractdog commented on code in PR #402:
URL: https://github.com/apache/tez/pull/402#discussion_r2698702161
##########
tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomTextWriter.java:
##########
@@ -180,71 +180,72 @@ public int run(String[] args) throws Exception {
}
Configuration conf = getConf();
- JobClient client = new JobClient(conf);
- ClusterStatus cluster = client.getClusterStatus();
- int numMapsPerHost = conf.getInt(MAPS_PER_HOST, 10);
- long numBytesToWritePerMap = conf.getLong(BYTES_PER_MAP,
- 1*1024*1024*1024);
- if (numBytesToWritePerMap == 0) {
- System.err.println("Cannot have " + BYTES_PER_MAP +" set to 0");
- return -2;
- }
- long totalBytesToWrite = conf.getLong(TOTAL_BYTES,
- numMapsPerHost*numBytesToWritePerMap*cluster.getTaskTrackers());
- int numMaps = (int) (totalBytesToWrite / numBytesToWritePerMap);
- if (numMaps == 0 && totalBytesToWrite > 0) {
- numMaps = 1;
- conf.setLong(BYTES_PER_MAP, totalBytesToWrite);
- }
- conf.setInt(MRJobConfig.NUM_MAPS, numMaps);
-
- Job job = new Job(conf);
-
- job.setJarByClass(RandomTextWriter.class);
- job.setJobName("random-text-writer");
-
- job.setOutputKeyClass(Text.class);
- job.setOutputValueClass(Text.class);
-
- job.setInputFormatClass(RandomWriter.RandomInputFormat.class);
- job.setMapperClass(RandomTextMapper.class);
-
- Class<? extends OutputFormat> outputFormatClass =
- SequenceFileOutputFormat.class;
- List<String> otherArgs = new ArrayList<String>();
- for(int i=0; i < args.length; ++i) {
- try {
- if ("-outFormat".equals(args[i])) {
- outputFormatClass =
- Class.forName(args[++i]).asSubclass(OutputFormat.class);
- } else {
- otherArgs.add(args[i]);
+ try (JobClient client = new JobClient(conf)) {
Review Comment:
same here
##########
tez-tests/src/main/java/org/apache/tez/mapreduce/examples/RandomWriter.java:
##########
@@ -246,51 +246,52 @@ public int run(String[] args) throws Exception {
Path outDir = new Path(args[0]);
Configuration conf = getConf();
- JobClient client = new JobClient(conf);
- ClusterStatus cluster = client.getClusterStatus();
- int numMapsPerHost = conf.getInt(MAPS_PER_HOST, 10);
- long numBytesToWritePerMap = conf.getLong(BYTES_PER_MAP,
- 1*1024*1024*1024);
- if (numBytesToWritePerMap == 0) {
- System.err.println("Cannot have" + BYTES_PER_MAP + " set to 0");
- return -2;
- }
- long totalBytesToWrite = conf.getLong(TOTAL_BYTES,
- numMapsPerHost*numBytesToWritePerMap*cluster.getTaskTrackers());
- int numMaps = (int) (totalBytesToWrite / numBytesToWritePerMap);
- if (numMaps == 0 && totalBytesToWrite > 0) {
- numMaps = 1;
- conf.setLong(BYTES_PER_MAP, totalBytesToWrite);
- }
- conf.setInt(MRJobConfig.NUM_MAPS, numMaps);
+ try (JobClient client = new JobClient(conf)) {
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
