abstractdog commented on code in PR #402:
URL: https://github.com/apache/tez/pull/402#discussion_r2698700536
##########
tez-tests/src/main/java/org/apache/tez/mapreduce/examples/Join.java:
##########
@@ -82,92 +82,95 @@ static int printUsage() {
@SuppressWarnings("deprecation")
public int run(String[] args) throws Exception {
Configuration conf = getConf();
- JobClient client = new JobClient(conf);
Review Comment:
would it make sense to refactor the method to use the JobClient to prevent
many indentation, like:
```
try (JobClient client = new JobClient(conf))
run(client)
}
private run (JobClient client) {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
